[ORCA] Remove the IntoClause related logic in the CTAS #978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Under PG14, for CTAS (or SELECT INTO), the `IntoClause` only exists in the parser stage and no longer exists in the Query structure. It was probably removed at PG9 ~ PG10? The logic related to `IntoClause` has been deleted from the current commit. And rewritten some CTAS interfaces. In addition, an ORCA fallback caused by an empty targetlist has been fixed. ``` explain select into empty_tl from generate_series(0, 100); ``` will get the fallabck when enable the cassert: ``` INFO: GPORCA failed to produce a plan, falling back to Postgres-based planner DETAIL: CTranslatorDXLToPlStmt.cpp:6154: Failed assertion: nullptr != target_list ```
jiaqizho
force-pushed
the
orca-refactor-ctas
branch
from
ad5bfed to
b1b8307
Compare
my-ship-it
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #ISSUE_Number
What does this PR do?
Type of Change
Breaking Changes
Test Plan
make installcheckmake -C src/test installcheck-cbdb-parallelImpact
Performance:
User-facing changes:
Dependencies:
Checklist
Additional Context
CI Skip Instructions