[WIP]Add git hooks for Cloudberry Database development #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For better development quality, we customize the Git hooks to remind developers to check their work. We use pre-commit, prepare-commit-msg, commit-msg, and pre-push hooks to trigger automatic checks when running `git commit` and `git push`.
|
wut'bout using https://github.com/jorisroovers/gitlint? I think introducing a python dependencies is far better than wiring unportable shell scripts that differs from shell to shell. besides, our |
|
Seems the PR is not active for a long time. Do we still need this? |
Please keep this PR for now. I will discuss this with our DevOps team. If no longer needed, then close it. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't merge this PR, until it is ready!
Change logs
For better development quality, we customize the Git hooks to remind developers to check their work. We use pre-commit, prepare-commit-msg, commit-msg, and pre-push hooks to trigger automatic checks when running
git commitandgit push.Why are the changes needed?
For better development quality
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Install the hooks in the new dir.
Contributor's Checklist
Here are some reminders and checklists before/when submitting your pull request, please check them:
make installcheckmake -C src/test installcheck-cbdb-parallel