Introduce cloudberry_fdw to run queries between one and more CBDB clusters #1147
Conversation
clusters cloudberry_fdw is an MPP version of the postgres_fdw foreign-data wrapper. While it behaves similarly to postgres_fdw in many respects, cloudberry_fdw uses a Cloudberry Database parallel retrieve cursor to pull data directly from the segments of a remote Cloudberry cluster to the segments in the local Cloudberry cluster, in parallel.
|
The code looks like it was copied from postgres_fdw. Please explain the reasons and considerations behind the work. Thanks |
| * postgres_fdw.h | ||
| * Foreign-data wrapper for remote PostgreSQL servers | ||
| * | ||
| * Portions Copyright (c) 2012-2021, PostgreSQL Global Development Group |
| * Portions Copyright (c) 2012-2021, PostgreSQL Global Development Group | ||
| * | ||
| * IDENTIFICATION | ||
| * contrib/postgres_fdw/postgres_fdw.h |
There was a problem hiding this comment.
-> contrib/cloudberry_fdw/cloudberry_fdw.h
+1, We need to keep the PostgreSQL code unchanged to preserve their commit history, contributions, and intellectual property. Directly copying it would lead to significant issues in future kernel upgrades. Even without these reasons, the code in postgres_fdw has been developed collaboratively by many individuals over the years, and we should respect their work and not take credit for it. |
|
Not sure, but do we have CI test for this fdw contrib? @edespino |
Fixes #ISSUE_Number
What does this PR do?
Type of Change
Breaking Changes
Test Plan
make installcheckmake -C src/test installcheck-cbdb-parallelImpact
Performance:
User-facing changes:
Dependencies:
Checklist
Additional Context
CI Skip Instructions