CASSGO-61 fix connection timeout override with custom #1866
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tengu-alt
changed the title
tengu-alt
force-pushed
the
conn-exec-override-timeout
branch
from
2704a12 to
deb64e8
Compare
tengu-alt
changed the title
tengu-alt
force-pushed
the
conn-exec-override-timeout
branch
2 times, most recently
from
951c58d to
ae2efae
Compare
tengu-alt
force-pushed
the
conn-exec-override-timeout
branch
from
ae2efae to
73bf8bb
Compare
cassandra_test.go
Outdated
| } | ||
| session.executor.pool.mu.Unlock() | ||
| err = session.Query("INSERT INTO gocql_test.named_query(id, value) VALUES(2, 'value')").Exec() | ||
| if err == nil || err != ErrTimeoutNoResponse { |
There was a problem hiding this comment.
If you are expecting exactly ErrTimeoutNoResponse, this part is redundant "err == nil" wdyt?
tengu-alt
force-pushed
the
conn-exec-override-timeout
branch
from
73bf8bb to
1d3d896
Compare
I've added the code example to the |
tengu-alt
force-pushed
the
conn-exec-override-timeout
branch
from
1d3d896 to
455a01c
Compare
OleksiienkoMykyta
approved these changes
Mar 24, 2025
joao-r-reis
changed the title
|
When the context is cancelled because it had a deadline, we aren't calling |
tengu-alt
force-pushed
the
conn-exec-override-timeout
branch
from
455a01c to
62d08a2
Compare
Agree. I've also added this check here in case if deadline hits before we create |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #953
This PR provides the fix for the connection timeout override via query context timeout, allowing users to set the custom timeout for the query.