CASSGO-57 Deprecate Session.ExecuteBatch() and move "execute batch" methods to Batch type #1865
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joao-r-reis
changed the title
|
@joao-r-reis Could you please take a look? |
joao-r-reis
previously approved these changes
Apr 21, 2025
joao-r-reis
reviewed
Apr 21, 2025
tengu-alt
force-pushed
the
deprecate-execute-batch
branch
from
35c009a to
84fc771
Compare
|
Looking good, can you resolve the conflicts? I think it's because I just merged the vector PR sorry. After that it's good to be merged. Oh also please add the changelog entry |
|
And format the commit message |
…Batch type Session.ExecuteBatch() was deprecated and similar methods(MapExecuteBatchCAS,ExecuteBatchCAS) were deprecated and moved to Batch type patch by Oleksandr Luzhniy; reviewed by João Reis, Bohdan Siryk, for CASSGO-57
tengu-alt
force-pushed
the
deprecate-execute-batch
branch
from
84fc771 to
7298f1c
Compare
|
@joao-r-reis Done! |
joao-r-reis
approved these changes
May 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR deprecates
Session.ExecuteBatch()and others similar methods(MapExecuteBatchCAS,ExecuteBatchCAS)