You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks for catching this — the declaration really was dead code, and the
generated schema confirmed the index had never existed.
I've landed the fix in ec45d2b rather than merging
this PR, because the rename alone doesn't hold up on MySQL: seven utf8mb4 varchar(255) columns need 7140 bytes of index key against InnoDB's 3072-byte
limit, which is the Error 1071 the CI run here hit. That commit narrows the
policy columns to varchar(100) (matching casbin's canonical schema and
gorm-adapter), and makes inserts ignore conflicts so that re-adding an
already-stored rule stays a no-op instead of becoming an error for replicas
whose in-memory model has fallen behind. The README now documents the
duplicate-row and over-long-value checks needed before upgrading an existing
database.
Closing in favour of that commit — but the diagnosis was yours, and it was a
good catch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.