Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sleep to give enough time for server to be up #34133

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Naireen
Copy link
Contributor

@Naireen Naireen commented Mar 1, 2025

From local tests, it looks like even though we publish 10 messages, the server isn't up yet, so we miss the first couple of messages which is why the assertions fail. What isn't clear to me is why that has transient failures, but the regular read test doesn't

History: https://develocity.apache.org/scans/tests?search.relativeStartTime=P28D&search.timeZoneId=America%2FLos_Angeles&tests.container=org.apache.beam.sdk.io.mqtt.MqttIOTest

This is flakey enough that you can see this running locally, but adding in a sleep got rid of it. Ideaaly there would be a nicer method of checking if the server was up and ready to accept messages, but couldn't figure out a nice quick easy way to do that.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@Naireen Naireen marked this pull request as ready for review March 2, 2025 01:18
Copy link
Contributor

github-actions bot commented Mar 2, 2025

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @kennknowles for label java.
R: @johnjcasey for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant