AVRO-4112: [C++][CMake] Do not find Boost when test is not built #3293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wgtmac
commented
Jan 17, 2025
| else () | ||
| find_package (Boost 1.38 REQUIRED COMPONENTS iostreams) | ||
| if (AVRO_BUILD_TESTS OR AVRO_USE_BOOST) | ||
| find_package (Boost 1.38 REQUIRED COMPONENTS system) |
There was a problem hiding this comment.
@thiru-mg I'm not sure if boost/system is required because I haven't found any header inclusion from all source files. Should we remove it as well?
There was a problem hiding this comment.
After some investigation, I think the system component is required for boost/asio, so let's keep it.
thiru-mg
approved these changes
Jan 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
AVRO_USE_BOOSTto indicate whether boost is required for non-test targets.Verifying this change
Documentation