AVRO-4110: Double Values Fail when using Min/Max #3292
+20
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems to be fixing the same bug as #3285 but in more methods. |
Agreed that there's overlap, but that I covered all the methods within PrimitivesArrays.DoubleArray. Also, I used the doubleValue instead of casting thus not using auto-boxing of the type thus ensuring the semantics of the following PR are followed: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Resolves AVRO-4110
Double Values Fail when using Min/Max
Verifying this change
(Please pick one of the following options)
I added tests to
PrimitivesArraysTestto cover the use case identified in the JIRA ticket.Documentation
Does this pull request introduce a new feature? (yes / no)
No
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)