AVRO-4109: [C++] Remove boost::program_options #3286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-g
approved these changes
Jan 10, 2025
Gerrit0
suggested changes
Jan 10, 2025
thiru-mg
reviewed
Jan 10, 2025
| return true; | ||
| } | ||
|
|
||
| if (arg == "-V" || arg == "--version") { |
There was a problem hiding this comment.
Should we also check if there are any more arguments? For example, if someone type avrogencpp -V -U, should we just show the version or error out?
There was a problem hiding this comment.
avrogencpp -V -U prints the version without my change. So I think it is consistent with the original behavior.
Gerrit0
approved these changes
Jan 11, 2025
wgtmac
force-pushed
the
program_options
branch
from
bc6e466 to
8fed3e0
Compare
|
Rebased to resolve the conflict. |
thiru-mg
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Remove boost::program_options
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Documentation