Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AVRO-4022: Add docker CI #3037

Merged
merged 9 commits into from
Jul 24, 2024
Merged

AVRO-4022: Add docker CI #3037

merged 9 commits into from
Jul 24, 2024

Conversation

Fokko
Copy link
Contributor

@Fokko Fokko commented Jul 23, 2024

What is the purpose of the change

Adding a test to the docker setup, to ensure that it keeps up to date.

After the changes, it also runs locally on my M3 arm64 mac:

➜  avro git:(fd-run-docker-tests) ✗  build.sh docker-test
...
➜  avro git:(fd-run-docker-tests) ✗  echo $?
0

Currently I only run this on master, since it takes quite a bit to run (40 minutes), or when the Dockerfile is changed.

Verifying this change

(Please pick one of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Extended interop tests to verify consistent valid schema names between SDKs
  • Added test that validates that Java throws an AvroRuntimeException on invalid binary data
  • Manually verified the change by building the website and checking the new redirect

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@github-actions github-actions bot added the build label Jul 23, 2024
@Fokko Fokko force-pushed the fd-run-docker-tests branch 4 times, most recently from 0e074d5 to 768d245 Compare July 23, 2024 08:51
@Fokko Fokko force-pushed the fd-run-docker-tests branch from 768d245 to afe0679 Compare July 23, 2024 08:53
@zcsizmadia
Copy link
Contributor

IIRC those exceptions are expected exceptions for checking an unsupported name, but will check later this week. I think the failed test reason is missing libssl package.

@Fokko
Copy link
Contributor Author

Fokko commented Jul 23, 2024

@zcsizmadia Thanks for jumping in here. I was doing some digging myself, and I think you're right. The exceptions are a red herring. It looks like this is because it needs OpenSSL1.1. I think this is part of upgrading Ubuntu to 22 which comes with a newer version of OpenSSL.

@zcsizmadia
Copy link
Contributor

Probably we should remove that exception to the console. It is confusing that it indicates a hard exception.

share/docker/Dockerfile Outdated Show resolved Hide resolved
@Fokko Fokko changed the title Add docker CI AVRO-4022: Add docker CI Jul 23, 2024
@Fokko Fokko force-pushed the fd-run-docker-tests branch 6 times, most recently from 591e247 to 0828aad Compare July 23, 2024 20:28
@Fokko Fokko force-pushed the fd-run-docker-tests branch from 0828aad to ba2206a Compare July 23, 2024 20:30
@Fokko Fokko marked this pull request as ready for review July 23, 2024 20:38
build.sh Outdated Show resolved Hide resolved
Co-authored-by: Martin Grigorov <[email protected]>
@Fokko
Copy link
Contributor Author

Fokko commented Jul 24, 2024

Thanks for the quick review @martin-g

@Fokko Fokko merged commit fc9380b into apache:main Jul 24, 2024
3 checks passed
@Fokko Fokko deleted the fd-run-docker-tests branch July 24, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants