Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AVRO-3865, AVRO-3866: [Build][Perl][Python] Refer to share/VERSION.txt rather than copy it #2508

Merged
merged 1 commit into from
Sep 22, 2023

Conversation

sarutak
Copy link
Member

@sarutak sarutak commented Sep 20, 2023

AVRO-3865
AVRO-3866

What is the purpose of the change

This PR proposes to change the build process of Perl and Python SDK not to copying share/VERSION.txt when we run lang/perl/build.sh dist or lang/py/build.sh doc.

Verifying this change

Done by CI.

Documentation

  • Does this pull request introduce a new feature? (no)

@sarutak
Copy link
Member Author

sarutak commented Sep 20, 2023

BTW, build.sh dist doesn't create lang/py/VERSION.txt because lang/py/build.sh dist doesn't generates doc for Python.
That issue will be resolved in #2509

@martin-g
Copy link
Member

They are created when we run lang/perl/build.sh doc

Actually the Perl build script has no doc target. It is the dist target that copies the file -

avro/lang/perl/build.sh

Lines 60 to 61 in a240ceb

dist)
cp ../../share/VERSION.txt .

IMO we should improve the build.sh scripts to clean up after themselves instead of hiding the files with .gitignore.

@sarutak
Copy link
Member Author

sarutak commented Sep 21, 2023

Actually the Perl build script has no doc target. It is the dist target that copies the file -

Sorry, it's a typo. I've modified it.

IMO we should improve the build.sh scripts to clean up after themselves instead of hiding the files with .gitignore.

Or, how about just referring to share/VERSION.txt rather than copying it.

@martin-g
Copy link
Member

Or, how about just referring to share/VERSION.txt rather than copying it.

Also OK if it works!

@sarutak sarutak changed the title AVRO-3865, AVRO-3866: [Build][Perl][Python] Add VERSION.txt to .gitignore AVRO-3865, AVRO-3866: [Build][Perl][Python] Refer to share/README.md rather than copy it Sep 21, 2023
@sarutak sarutak changed the title AVRO-3865, AVRO-3866: [Build][Perl][Python] Refer to share/README.md rather than copy it AVRO-3865, AVRO-3866: [Build][Perl][Python] Refer to share/VERSION.txt rather than copy it Sep 21, 2023
@martin-g martin-g merged commit 032d5ac into apache:master Sep 22, 2023
martin-g pushed a commit that referenced this pull request Sep 22, 2023
…t rather than copy it (#2508)

(cherry picked from commit 032d5ac)
@martin-g
Copy link
Member

Thank you, @sarutak !

@RyanSkraba
Copy link
Contributor

Wow -- thanks so much for this speedy fix :D It's magic to me when a contributor picks up a to do item that's been bugging me for ages ❤️

RanbirK pushed a commit to RanbirK/avro that referenced this pull request May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants