-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AVRO-3865, AVRO-3866: [Build][Perl][Python] Refer to share/VERSION.txt rather than copy it #2508
Conversation
BTW, |
Actually the Perl build script has no Lines 60 to 61 in a240ceb
IMO we should improve the build.sh scripts to clean up after themselves instead of hiding the files with .gitignore. |
Sorry, it's a typo. I've modified it.
Or, how about just referring to |
Also OK if it works! |
…t rather than copy it
Thank you, @sarutak ! |
Wow -- thanks so much for this speedy fix :D It's magic to me when a contributor picks up a to do item that's been bugging me for ages ❤️ |
…t rather than copy it (apache#2508)
AVRO-3865
AVRO-3866
What is the purpose of the change
This PR proposes to change the build process of Perl and Python SDK not to copying
share/VERSION.txt
when we runlang/perl/build.sh dist
orlang/py/build.sh doc
.Verifying this change
Done by CI.
Documentation