GH-50219: [R] Fix duckdb test for dbplyr 2.6.0#50220
Conversation
|
@github-actions crossbow submit test-r-depsource-system test-r-gcc-11 test-r-gcc-12 test-r-m1-san test-r-offline-maximal test-r-versions |
There was a problem hiding this comment.
Pull request overview
Fixes an R test failure caused by dbplyr 2.6.0 changing how remote_con() retrieves the connection from a tbl.
Changes:
- Update the DuckDB integration test to override
ds_rt$con(instead ofds_rt$src$con) so the simulated “non-DuckDB connection” path still triggers the expectedto_arrow()error withdbplyr2.6.0.
|
Revision: a468619 Submitted crossbow builds: ursacomputing/crossbow @ actions-74af3d833c
|
| # Now check errors | ||
| # dbplyr 2.6.0 added "con" to the allowed $ fields on tbl_lazy; | ||
| # older versions only allow "src" and "lazy_query" | ||
| skip_if(packageVersion("dbplyr") < "2.6.0") |
There was a problem hiding this comment.
Needs skipping or fails on CI with cached dbplyr with old syntax
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit d6bba6b. There were 2 benchmark results indicating a performance regression:
The full Conbench report has more details. It also includes information about 216 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Rationale for this change
dbplyr 2.6.0 changed
remote_con()to read fromx$coninstead ofx$src$con. The duckdb test that simulates a non-DuckDB connection was overriding the old path, so the expected error was no longer thrown.What changes are included in this PR?
Update the test to override
ds_rt$coninstead ofds_rt$src$con.Are these changes tested?
This is a test fix — the test itself verifies the behavior.
Are there any user-facing changes?
No.