GH-49923: [Parquet][Python] Inconsistent default values for Parquet pre_buffer#49924
Merged
pitrou merged 1 commit intoapache:mainfrom May 6, 2026
Merged
GH-49923: [Parquet][Python] Inconsistent default values for Parquet pre_buffer#49924pitrou merged 1 commit intoapache:mainfrom
pitrou merged 1 commit intoapache:mainfrom
Conversation
|
|
github-actions
Bot
added
Component: Python
awaiting committer review
pitrou
approved these changes
May 6, 2026
Member
pitrou
left a comment
pitrou
left a comment
There was a problem hiding this comment.
+1, let's hope CI doesn't break
|
After merging your PR, Conbench analyzed the 0 benchmarking runs that have been run so far on merge-commit 2a89d03. None of the specified runs were found on the Conbench server. The full Conbench report has more details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Default
pre_buffer=Trueon parquet APIs should probably be made consistent.What changes are included in this PR?
Couple of default parameter changes and an updated docstring.
Are these changes tested?
By CI.
Are there any user-facing changes?
Users will see changes to default behavior. It's hard to estimate how disruptive (if at all) this will be.
pre_buffer#49923