GH-49921: [C++] Bump xsimd to 14.2.0#49922
Conversation
|
|
|
@AntoinePrv Can you take a look at the CI failures? They seem related. |
|
Yes, I am still waiting for the Msys2 build of xsimd to happen... |
|
There are failures on non-MSys2 builds, though: |
|
Perhaps it's this check that does not work on MSVC? Either we could add |
|
I think we should both 1) fix xsimd upstream anyway and 2) pass It seems xsimd should do something like this: #ifdef _MSVC_LANG
#define XSIMD_CPP_LEVEL _MSVC_LANG
#else
#define XSIMD_CPP_LEVEL __cplusplus
#endifand then use the (but xsimd could also use find-grained feature testing). |
|
Already sending a patch, but not sure I want to go through another round of xsimd releases |
|
Agreed, hence "pass /Zc:__cplusplus when building Arrow C++" as well 😉 |
|
Bloody protobuf fails building with |
|
Tiny syntax error that needs fixing: |
|
@pitrou I'm not very proactively working on this until the msys2 xsimd build is live |
|
@github-actions crossbow submit -g cpp |
|
Revision: 89a1f7e Submitted crossbow builds: ursacomputing/crossbow @ actions-9c434593fe |
It's just a matter of waiting for their queue to update it: Based on experience when uploading Arrow it takes between 6 and 12 hours. Their CI seems to run several times a day and xsimd is already listed on the queue so it should be available "soon". |
Rationale for this change
Fix SVE dynamic dispatch ODR violation xtensor-stack/xsimd#1311
What changes are included in this PR?
Bump version and cleanup backports.
Are these changes tested?
Yes, in CI.
Are there any user-facing changes?
No