Skip to content

GH-49772: [C++] Bump bundled mimalloc version#49801

Merged
raulcd merged 6 commits intoapache:mainfrom
raulcd:GH-49772
May 5, 2026
Merged

GH-49772: [C++] Bump bundled mimalloc version#49801
raulcd merged 6 commits intoapache:mainfrom
raulcd:GH-49772

Conversation

@raulcd
Copy link
Copy Markdown
Member

@raulcd raulcd commented Apr 20, 2026

Rationale for this change

mimalloc 3.3.1 was released with a bunch of potentially useful improvements or fixes.

What changes are included in this PR?

Bump bundled mimalloc to 3.3.1

Are these changes tested?

Yes, via Archery

Are there any user-facing changes?

No

@raulcd raulcd added CI: Extra: C++ Run extra C++ CI CI: Extra: R Run extra R CI labels Apr 20, 2026
@pitrou
Copy link
Copy Markdown
Member

pitrou commented Apr 20, 2026

3.3.1 was just released, FTR :)

@github-actions github-actions Bot removed the CI: Extra: C++ Run extra C++ CI label Apr 21, 2026
@raulcd raulcd marked this pull request as ready for review April 22, 2026 06:57
@raulcd raulcd requested review from kou and pitrou April 27, 2026 07:49
@pitrou pitrou added the CI: Extra: C++ Run extra C++ CI label Apr 27, 2026
@pitrou
Copy link
Copy Markdown
Member

pitrou commented Apr 27, 2026

@github-actions crossbow submit -g cpp

@pitrou
Copy link
Copy Markdown
Member

pitrou commented Apr 27, 2026

@ursabot please benchmark lang=C++

@rok
Copy link
Copy Markdown
Member

rok commented Apr 27, 2026

Benchmark runs are scheduled for commit dd3ce38. Watch https://buildkite.com/apache-arrow and https://conbench.arrow-dev.org for updates. A comment will be posted here when the runs are complete.

@github-actions
Copy link
Copy Markdown

Revision: dd3ce38

Submitted crossbow builds: ursacomputing/crossbow @ actions-a1dcd2c5d1

Task Status
example-cpp-minimal-build-static GitHub Actions
example-cpp-minimal-build-static-system-dependency GitHub Actions
example-cpp-tutorial GitHub Actions
test-build-cpp-fuzz GitHub Actions
test-conda-cpp GitHub Actions
test-conda-cpp-valgrind GitHub Actions
test-debian-13-cpp-amd64 GitHub Actions
test-debian-13-cpp-i386 GitHub Actions
test-debian-experimental-cpp-gcc-15 GitHub Actions
test-fedora-42-cpp GitHub Actions
test-ubuntu-22.04-cpp GitHub Actions
test-ubuntu-22.04-cpp-20 GitHub Actions
test-ubuntu-22.04-cpp-bundled GitHub Actions
test-ubuntu-22.04-cpp-emscripten GitHub Actions
test-ubuntu-22.04-cpp-no-threading GitHub Actions
test-ubuntu-24.04-cpp GitHub Actions
test-ubuntu-24.04-cpp-bundled-offline GitHub Actions
test-ubuntu-24.04-cpp-gcc-13-bundled GitHub Actions
test-ubuntu-24.04-cpp-gcc-14 GitHub Actions
test-ubuntu-24.04-cpp-minimal-with-formats GitHub Actions
test-ubuntu-24.04-cpp-thread-sanitizer GitHub Actions

@conbench-apache-arrow
Copy link
Copy Markdown

Thanks for your patience. Conbench analyzed the 3 benchmarking runs that have been run so far on PR commit dd3ce38.

There were 13 benchmark results indicating a performance regression:

The full Conbench report has more details.

@raulcd
Copy link
Copy Markdown
Member Author

raulcd commented Apr 27, 2026

There seems to be a big regression on the memory pool benchmark on the TouchArea benchmark.
An example of one of the tests:
From mean: 110,760,324,636.8867 B/s
To mean: 84,367,944,824.52159 B/s
-23.83%
If I am interpreting the numbers correctly.

@pitrou
Copy link
Copy Markdown
Member

pitrou commented Apr 27, 2026

It's a very synthetic benchmark and doesn't measure any real-world operation, so I think we can ignore it.

@raulcd
Copy link
Copy Markdown
Member Author

raulcd commented Apr 27, 2026

It's a very synthetic benchmark and doesn't measure any real-world operation, so I think we can ignore it.

ok, then I don't think the rest of CI failures are related.

Copy link
Copy Markdown
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Comment thread cpp/cmake_modules/ThirdpartyToolchain.cmake Outdated
@github-actions github-actions Bot added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels Apr 29, 2026
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
@github-actions github-actions Bot removed the CI: Extra: C++ Run extra C++ CI label Apr 29, 2026
@github-actions github-actions Bot added awaiting changes Awaiting changes and removed awaiting merge Awaiting merge labels Apr 29, 2026
@raulcd raulcd merged commit f0beefb into apache:main May 5, 2026
86 of 93 checks passed
@raulcd raulcd removed the awaiting changes Awaiting changes label May 5, 2026
@raulcd raulcd deleted the GH-49772 branch May 5, 2026 08:14
@conbench-apache-arrow
Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 0 benchmarking runs that have been run so far on merge-commit f0beefb.

None of the specified runs were found on the Conbench server.

The full Conbench report has more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants