GH-49783: [C++][FlightRPC][ODBC] Reuse connections across test suite#49784
Open
justing-bq wants to merge 4 commits intoapache:mainfrom
Open
GH-49783: [C++][FlightRPC][ODBC] Reuse connections across test suite#49784justing-bq wants to merge 4 commits intoapache:mainfrom
justing-bq wants to merge 4 commits intoapache:mainfrom
Conversation
|
|
github-actions
Bot
added
awaiting review
Contributor
Author
There was a problem hiding this comment.
Pull request overview
This PR refactors the Flight SQL ODBC C++ test suite to reuse ODBC environment/connection handles across the entire test run (global SetUp/TearDown), reducing connect/disconnect churn that can crash tests on Linux.
Changes:
- Introduces shared handle pools (remote/mock, ODBC v2/v3, plus “non-connection” handles) and rewires fixtures to point
env/conn/stmtat the appropriate shared handles. - Moves remote/mock connection establishment into a global
::testing::Environmentand updates helper APIs (Connect,Disconnect, etc.) to accept explicit handle references. - Adjusts a few tests to use the new connection helper signature and adds a Windows-only CMake source tweak.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| cpp/src/arrow/flight/sql/odbc/tests/odbc_test_suite.h | Adds shared handle structs/pools and updates test base APIs to take explicit handles. |
| cpp/src/arrow/flight/sql/odbc/tests/odbc_test_suite.cc | Implements a global test environment that connects once and reuses handles across suites/tests. |
| cpp/src/arrow/flight/sql/odbc/tests/connection_info_test.cc | Updates handle-based tests to call ConnectWithString(..., conn). |
| cpp/src/arrow/flight/sql/odbc/tests/connection_attr_test.cc | Allocates a local env/conn for a DM-only attribute test and uses new helpers. |
| cpp/src/arrow/flight/sql/odbc/tests/CMakeLists.txt | Adds a Windows-only extra source intended to address a Windows crash. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lidavidm
reviewed
Apr 19, 2026
Member
lidavidm
left a comment
lidavidm
left a comment
There was a problem hiding this comment.
Is there an issue for tracking down the cause of the crash?
github-actions
Bot
added
awaiting review
Collaborator
We have an issue here: #48270 |
Collaborator
|
Could we resolve the merge conflict? |
justing-bq
force-pushed
the
gh-49783-reuse-test-connections
branch
from
f497c6b to
eb7732b
Compare
justing-bq
requested review from
assignUser,
jonkeane,
kou and
raulcd
as code owners
github-actions
Bot
added
Component: Documentation
awaiting change review
justing-bq
force-pushed
the
gh-49783-reuse-test-connections
branch
from
eb7732b to
12386aa
Compare
justing-bq
force-pushed
the
gh-49783-reuse-test-connections
branch
from
12386aa to
f43b2ce
Compare
alinaliBQ
approved these changes
Apr 23, 2026
Contributor
Author
justing-bq
force-pushed
the
gh-49783-reuse-test-connections
branch
from
f43b2ce to
e13e14c
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 12 out of 12 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
justing-bq
force-pushed
the
gh-49783-reuse-test-connections
branch
3 times, most recently
from
1580dbd to
0f25fe5
Compare
Co-Authored-By: Alina (Xi) Li <96995091+alinaliBQ@users.noreply.github.com>
justing-bq
force-pushed
the
gh-49783-reuse-test-connections
branch
from
0f25fe5 to
1f5db13
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
We avoid crashing tests on Linux if we minimize the number of connect/disconnect attempts. So now we are reusing the same connection as much as possible throughout the tests.
What changes are included in this PR?
All our necessary connections happen during global
SetUp()and then they get disconnected during globalTearDown().Test Fixture SetUp logic is now about updating pointers to the correct environment, connection, and statement handles for those tests.
Are these changes tested?
Yes.
Are there any user-facing changes?
No.