Skip to content

GH-49456: [C++] Use static key/item/value field names for map type again #49457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
raulcd merged 2 commits into from
Mar 5, 2026
Merged

GH-49456: [C++] Use static key/item/value field names for map type again #49457

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
30a6966
GH-49456: [C++] Use static key/item/value field names for map type again
kou Mar 5, 2026
097c917
Add a comment
kou Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion cpp/src/arrow/ipc/metadata_internal.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,7 +390,20 @@ Status ConcreteTypeFromFlatbuffer(flatbuf::Type type, const void* type_data,
return Status::Invalid("Map's keys must be non-nullable");
} else {
auto map = static_cast<const flatbuf::Map*>(type_data);
*out = std::make_shared<MapType>(children[0], map->keysSorted());
// We always use "key"/"value"/"entries" field names instead
// of field names in FlatBuffers because the specification
// defines them:
//
// https://github.com/apache/arrow/blob/apache-arrow-23.0.1/format/Schema.fbs#L127-L130
//
// In a field with Map type, the field has a child Struct
// field, which then has two children: the key type and the
// value type. The names of the child fields may be
// respectively "entries", "key", and "value", but this is
// not enforced.
*out = std::make_shared<MapType>(children[0]->type()->field(0)->WithName("key"),
children[0]->type()->field(1)->WithName("value"),
map->keysSorted());
}
return Status::OK();
case flatbuf::Type::Type_FixedSizeList:
Expand Down
Loading