GH-49426: [Python] Do not build pyarrow-stubs on emscripten builds#49427
Conversation
|
|
github-actions
Bot
added
Component: Python
awaiting committer review
|
@github-actions crossbow submit test-conda-python-emscripten |
|
Revision: 6b666d1 Submitted crossbow builds: ursacomputing/crossbow @ actions-e5e8b8cfe9
|
…tly fail blocking it
|
@github-actions crossbow submit test-conda-python-emscripten |
|
Revision: 3bd04d8 Submitted crossbow builds: ursacomputing/crossbow @ actions-99893ace2c
|
|
@github-actions crossbow submit test-conda-python-emscripten |
|
Revision: d5b2027 Submitted crossbow builds: ursacomputing/crossbow @ actions-50151f5e3d
|
| address = q.get(timeout=50) | ||
| time.sleep(0.1) # wait to make sure server is started | ||
| yield address | ||
| p.terminate() |
There was a problem hiding this comment.
As per claude threading.Thread.terminate doesn't exists, but this is not really an issue here.
| if is_emscripten: | ||
| # stubs are not supported in Emscripten build | ||
| return |
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit edfb24d. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them. |
…lds (apache#49427) ### Rationale for this change The emscripten job is currently failing due to pyarrow-stubs building. ### What changes are included in this PR? - Do not build doc stubs for emscripten build as it tries to install pyarrow which is unavailable. - Minor fix for chrome as it was timing out without being able to download wasm wheel. - Fix loading tzdata as some tests were failing without it. ### Are these changes tested? Yes via archery. ### Are there any user-facing changes? No * GitHub Issue: apache#49426 Authored-by: Raúl Cumplido <raulcumplido@gmail.com> Signed-off-by: Rok Mihevc <rok@mihevc.org>
…lds (apache#49427) ### Rationale for this change The emscripten job is currently failing due to pyarrow-stubs building. ### What changes are included in this PR? - Do not build doc stubs for emscripten build as it tries to install pyarrow which is unavailable. - Minor fix for chrome as it was timing out without being able to download wasm wheel. - Fix loading tzdata as some tests were failing without it. ### Are these changes tested? Yes via archery. ### Are there any user-facing changes? No * GitHub Issue: apache#49426 Authored-by: Raúl Cumplido <raulcumplido@gmail.com> Signed-off-by: Rok Mihevc <rok@mihevc.org>
2 participants
Rationale for this change
The emscripten job is currently failing due to pyarrow-stubs building.
What changes are included in this PR?
Are these changes tested?
Yes via archery.
Are there any user-facing changes?
No