GH-49422: [CI][Integration][Ruby] Add the Ruby implementation#49423
Merged
Conversation
|
|
ce220a9 to
b5b1a33
Compare
Member
Author
|
This is ready. |
67857c9 to
2bf38f5
Compare
2bf38f5 to
0aa7d88
Compare
Member
Author
|
I'll merge this in the next week if nobody objects it. |
Member
Author
|
I'll merge this. |
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit ed37b14. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them. |
thisisnic
pushed a commit
to thisisnic/arrow
that referenced
this pull request
Apr 6, 2026
…pache#49423) ### Rationale for this change There are some missing features in the Ruby implmentaion for now but we can pass them by skipping some tests in our integration tests. ### What changes are included in this PR? Archery: * Add `--with-ruby` to `archery integration` * Add `archery.integration.tester_ruby.RubyTester` * Add `no_map_field_names_validate` quirk for apacheGH-49415 * Show environment variables too on external command failure because Ruby tester uses environment variables not command line arguments to pass information to integration tester * Use `ARCHERY_INTEGRATION_WITH_CPP=1` instead of `ARROW_INTEGRATION_CPP=ON` like other implementations such as `ARCHERY_INTEGRATION_WITH_GO` Ruby: * Add `red-arrow-format-integration-test` as the test driver * This is not included in `.gem` because this is only for development * Add `ruby/red-arrow-format/lib/arrow-format/integration/` as helpers of the test driver * This is not included in `.gem` because this is only for development * Add `ArrowFormat::Array#empty?` * Add `ArrowFormat::RecordBatch#empty?` * Add `ArrowFormat::NullArray#n_nulls` * `ArrowFormat::*Array#to_a`: Add support for empty case * Fix Apache Arrow decimal <-> `BigDecimal` conversion * `ArrowFormat::Bitmap#each`: Fix a bug that one bit is ignored * Move dictionary ID to `ArrowFormat::DictionaryType` from `ArrowFormat::Field` * Add support for V4 union that has validity bitmap * Add support for no continuation token message for backward compatibility * `ArrowFormat::StreamingReader`: Add support for reading schema without calling `#each` * `ArrowFormat::MapType`: Add support for keys sorted * `ArrowFormat::MapType`: Always use "key"/"value"/"entries" for field names ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * GitHub Issue: apache#49422 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Mottl
pushed a commit
to Mottl/arrow
that referenced
this pull request
May 26, 2026
…pache#49423) ### Rationale for this change There are some missing features in the Ruby implmentaion for now but we can pass them by skipping some tests in our integration tests. ### What changes are included in this PR? Archery: * Add `--with-ruby` to `archery integration` * Add `archery.integration.tester_ruby.RubyTester` * Add `no_map_field_names_validate` quirk for apacheGH-49415 * Show environment variables too on external command failure because Ruby tester uses environment variables not command line arguments to pass information to integration tester * Use `ARCHERY_INTEGRATION_WITH_CPP=1` instead of `ARROW_INTEGRATION_CPP=ON` like other implementations such as `ARCHERY_INTEGRATION_WITH_GO` Ruby: * Add `red-arrow-format-integration-test` as the test driver * This is not included in `.gem` because this is only for development * Add `ruby/red-arrow-format/lib/arrow-format/integration/` as helpers of the test driver * This is not included in `.gem` because this is only for development * Add `ArrowFormat::Array#empty?` * Add `ArrowFormat::RecordBatch#empty?` * Add `ArrowFormat::NullArray#n_nulls` * `ArrowFormat::*Array#to_a`: Add support for empty case * Fix Apache Arrow decimal <-> `BigDecimal` conversion * `ArrowFormat::Bitmap#each`: Fix a bug that one bit is ignored * Move dictionary ID to `ArrowFormat::DictionaryType` from `ArrowFormat::Field` * Add support for V4 union that has validity bitmap * Add support for no continuation token message for backward compatibility * `ArrowFormat::StreamingReader`: Add support for reading schema without calling `#each` * `ArrowFormat::MapType`: Add support for keys sorted * `ArrowFormat::MapType`: Always use "key"/"value"/"entries" for field names ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * GitHub Issue: apache#49422 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
There are some missing features in the Ruby implmentaion for now but we can pass them by skipping some tests in our integration tests.
What changes are included in this PR?
Archery:
--with-rubytoarchery integrationarchery.integration.tester_ruby.RubyTesterno_map_field_names_validatequirk for [C++] Map type ignores key/item/value field names #49415ARCHERY_INTEGRATION_WITH_CPP=1instead ofARROW_INTEGRATION_CPP=ONlike other implementations such asARCHERY_INTEGRATION_WITH_GORuby:
red-arrow-format-integration-testas the test driver.gembecause this is only for developmentruby/red-arrow-format/lib/arrow-format/integration/as helpers of the test driver.gembecause this is only for developmentArrowFormat::Array#empty?ArrowFormat::RecordBatch#empty?ArrowFormat::NullArray#n_nullsArrowFormat::*Array#to_a: Add support for empty caseBigDecimalconversionArrowFormat::Bitmap#each: Fix a bug that one bit is ignoredArrowFormat::DictionaryTypefromArrowFormat::FieldArrowFormat::StreamingReader: Add support for reading schema without calling#eachArrowFormat::MapType: Add support for keys sortedArrowFormat::MapType: Always use "key"/"value"/"entries" for field namesAre these changes tested?
Yes.
Are there any user-facing changes?
Yes.