GH-49389: [Ruby] Add support for custom metadata in field and schema#49390
Merged
Conversation
|
|
hiroyuki-sato
approved these changes
Feb 25, 2026
Collaborator
There was a problem hiding this comment.
+1
LD_LIBRARY_PATH=/tmp/local/lib:/path/to/arrow/red-arrow/ext/arrow/ GI_TYPELIB_PATH=/tmp/local/lib/girepository-1.0 rake -I /path/to/arrow/ruby/red-arrow/lib test
cd /path/to/arrow/ruby/red-arrow-format
/path/to/.rbenv/versions/3.4.7/bin/ruby test/run.rb
Loaded suite test
Started
/path/to/arrow/ruby/red-arrow-format/lib/arrow-format/file-reader.rb:41: warning: IO::Buffer is experimental and both the Ruby and C interface may change in the future!
Finished in 3.256675261 seconds.
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
292 tests, 292 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
89.66 tests/s, 89.66 assertions/s
cd -
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit dc5b76e. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them. |
thisisnic
pushed a commit
to thisisnic/arrow
that referenced
this pull request
Apr 6, 2026
…chema (apache#49390) ### Rationale for this change We can add custom metadata to `Field` and `Schema`. ### What changes are included in this PR? * Add `ArrowFormat::Field#metadata` * Add `ArrowFormat::Schema#metadata` * Add support for reading and writing custom metadata in `Field` and `Schema` ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * GitHub Issue: apache#49389 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
We can add custom metadata to
FieldandSchema.What changes are included in this PR?
ArrowFormat::Field#metadataArrowFormat::Schema#metadataFieldandSchemaAre these changes tested?
Yes.
Are there any user-facing changes?
Yes.