GH-49292: [C++] Add support for armv8 or later#49337
Merged
Merged
Conversation
|
|
github-actions
Bot
added
Component: C++
awaiting committer review
Member
Author
|
This is based on the information from a Debian developer: https://salsa.debian.org/science-team/arrow/-/merge_requests/1#note_724736 |
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 74026cd. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 42 possible false positives for unstable benchmarks that are known to sometimes produce them. |
thisisnic
pushed a commit
to thisisnic/arrow
that referenced
this pull request
Apr 6, 2026
### Rationale for this change armv8 may be 32bit or 64bit. `armv8l` uses 32bit and others use 64bit. ### What changes are included in this PR? Use `aarch32` for `armv[4-7]` and `armv8l`. User `aarch64` for other `armv*`. ### Are these changes tested? No. ### Are there any user-facing changes? Yes. * GitHub Issue: apache#49292 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
armv8 may be 32bit or 64bit.
armv8luses 32bit and others use 64bit.What changes are included in this PR?
Use
aarch32forarmv[4-7]andarmv8l. Useraarch64for otherarmv*.Are these changes tested?
No.
Are there any user-facing changes?
Yes.