Skip to content

GH-49004: [C++][FlightRPC] Run ODBC tests in workflow using cpp_test.sh #49005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kou merged 5 commits into from
Feb 6, 2026
Merged

GH-49004: [C++][FlightRPC] Run ODBC tests in workflow using cpp_test.sh #49005

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bce9776
Run ODBC tests in workflow
alinaliBQ Jan 27, 2026
da8c9f2
Attempt to enable `cpp_test.sh`
alinaliBQ Jan 28, 2026
a895e28
Disable `find_package(Arrow)` check
alinaliBQ Jan 28, 2026
717a71c
Remove extra ODBC test steps
alinaliBQ Jan 28, 2026
3988957
Follow alphabetical order
alinaliBQ Feb 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions .github/workflows/cpp_extra.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,6 +352,9 @@ jobs:
ARROW_BUILD_STATIC: OFF
ARROW_BUILD_TESTS: ON
ARROW_BUILD_TYPE: release
# Turn Arrow CSV off to disable `find_package(Arrow)` check on MSVC CI.
# GH-49050 TODO: enable `find_package(Arrow)` check on MSVC CI.
ARROW_CSV: OFF
Comment on lines +355 to +357
Copy link
Copy Markdown
Collaborator Author

@alinaliBQ alinaliBQ Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found segmentation fault at find_package(Arrow) example in cpp_test.sh that doesn't seem to be ODBC-related. Raised #49050

Comment thread
alinaliBQ marked this conversation as resolved.
ARROW_DEPENDENCY_SOURCE: VCPKG
ARROW_FLIGHT_SQL_ODBC: ON
ARROW_FLIGHT_SQL_ODBC_INSTALLER: ON
Expand Down Expand Up @@ -434,10 +437,15 @@ jobs:
shell: cmd
run: |
call "cpp\src\arrow\flight\sql\odbc\tests\install_odbc.cmd" ${{ github.workspace }}\build\cpp\%ARROW_BUILD_TYPE%\arrow_flight_sql_odbc.dll
# GH-48270 TODO: Resolve segementation fault during Arrow library unload
# GH-48269 TODO: Enable Flight & Flight SQL testing in MSVC CI
# GH-48547 TODO: enable ODBC tests after GH-48270 and GH-48269 are resolved.

- name: Test
shell: cmd
run: |
set VCPKG_ROOT_KEEP=%VCPKG_ROOT%
call "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Auxiliary\Build\vcvarsall.bat" x64
set VCPKG_ROOT=%VCPKG_ROOT_KEEP%
# Convert VCPKG Windows path to MSYS path
for /f "usebackq delims=" %%I in (`bash -c "cygpath -u \"$VCPKG_ROOT_KEEP\""` ) do set VCPKG_ROOT=%%I
bash -c "ci/scripts/cpp_test.sh $(pwd) $(pwd)/build"
- name: Install WiX Toolset
shell: pwsh
run: |
Expand Down