Skip to content

GH-48560: [C++][Parquet] When fuzzing, treat Table validation error as hard error #48863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pitrou wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −3
Open

GH-48560: [C++][Parquet] When fuzzing, treat Table validation error as hard error #48863

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions cpp/src/parquet/arrow/fuzz_internal.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
#include "arrow/table.h"
#include "arrow/util/base64.h"
#include "arrow/util/fuzz_internal.h"
#include "arrow/util/logging.h"
#include "arrow/util/string.h"
#include "parquet/arrow/reader.h"
#include "parquet/bloom_filter.h"
Expand Down Expand Up @@ -95,16 +96,20 @@ std::shared_ptr<DecryptionKeyRetriever> MakeKeyRetriever() {
namespace {

Status FuzzReadData(std::unique_ptr<FileReader> reader) {
auto st = Status::OK();
auto final_status = Status::OK();
for (int i = 0; i < reader->num_row_groups(); ++i) {
std::shared_ptr<Table> table;
auto row_group_status = reader->ReadRowGroup(i, &table);
if (row_group_status.ok()) {
// When reading returns successfully, the Arrow data should be structurally
// valid so that it can be read normally. If that is not the case, abort
// so that the error can be published by OSS-Fuzz.
ARROW_CHECK_OK(table->Validate());
row_group_status &= table->ValidateFull();
}
st &= row_group_status;
final_status &= row_group_status;
}
return st;
return final_status;
}

template <typename DType>
Expand Down
Loading