MINOR: [C++] Remove obsolete todo about NaN handling at compare.cc#48694
Merged
kou merged 1 commit intoapache:mainfrom Jan 1, 2026
Merged
MINOR: [C++] Remove obsolete todo about NaN handling at compare.cc#48694kou merged 1 commit intoapache:mainfrom
kou merged 1 commit intoapache:mainfrom
Conversation
0abe5ac to
413568d
Compare
Member
Author
|
Thank you @kou !!!! |
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 960f0d2. There weren't enough matching historic benchmark results to make a call on whether there were regressions. The full Conbench report has more details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
52d615d added this todo.
arrow/cpp/src/arrow/compare.cc
Line 64 in 52d615d
After 4 years later, 72d20ad implemented the logic
arrow/cpp/src/arrow/compare.cc
Line 92 in 37c40fb
arrow/cpp/src/arrow/compare.cc
Line 116 in 37c40fb
This is being tested in
arrow/cpp/src/arrow/array/array_test.cc
Lines 2314 to 2316 in 37c40fb
What changes are included in this PR?
This PR removes the obsolete todo about NaN handling at compare.cc.
Are these changes tested?
No, I did not test.
Are there any user-facing changes?
No.