GH-46574: [C++][FlightRPC] ODBC Driver Connectivity support #47971
+858
−355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
Component: C++
Component: FlightRPC
awaiting review
alinaliBQ
commented
Oct 27, 2025
github-actions
bot
added
awaiting committer review
* SQLDriverConnect requires SQLGetInfo to be implemented for tests to pass, because driver manager requires SQLGetInfo Co-Authored-By: alinalibq <[email protected]>
Co-authored-by: justing-bq <[email protected]>
alinaliBQ
force-pushed
the
gh-46574-driver-connectivity
branch
from
5746a62 to
7d61b61
Compare
Co-authored-by: justing-bq <[email protected]>
alinaliBQ
force-pushed
the
gh-46574-driver-connectivity
branch
from
f28ed1f to
8ad5b6a
Compare
alinaliBQ
referenced
this pull request
in Bit-Quill/arrow
Oct 29, 2025
* use suggestion from James for one-liner change to return `Status::OK` directly * fix for iterating endpoints, it is based on JDBC's fix for the same bug * save value of `FlightClientOptions` * Use `TestFlightServer` Add `arrow_flight_sql_shared` to enable usages for `TestFlightServer` * Fix build errors from missing `gmock` * Add checks for array data Update flight_sql_stream_chunk_buffer_test.cc Add `FlightStreamChunkBufferTest` unit test Draft test with `FlightSQLODBCMockEndpointTestBase` * Reference apacheGH-47117 and Clean up code * Add driver and DSN to built-in properties to not pass driver/dsn as attributes to server * Allow `=` in values inside connection strings, fixes connectivity problems * Address comments from Rob
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Add ODBC driver connection support for the driver, so the driver can connect to servers.
What changes are included in this PR?
Implementation of unicode APIs:
Are these changes tested?
Tested locally on Windows.
Note that this PR depends on #47763 to get tests passing.
Are there any user-facing changes?
N/A