Skip to content

Conversation

@amoeba
Copy link
Member

@amoeba amoeba commented Oct 17, 2025

Rationale for this change

For certain C++ build configurations, we require patch to be in the user's PATH. This was introduced in e1f727c and a Discussion pointed this out. For Linux and macOS, it's pretty reasonable for us to assume patch is available but not on Windows.

What changes are included in this PR?

Adds a note in the "Debug" section of the Windows docs.

Are these changes tested?

Yes, I'll add a screenshot to make review easier.

Are there any user-facing changes?

No.

@github-actions
Copy link

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

See also:

@amoeba
Copy link
Member Author

amoeba commented Oct 17, 2025

Build and previewed locally, here's how this looks:

Screenshot 2025-10-16 at 6 28 39 PM

@adamreeve adamreeve changed the title MIONR: [Docs] Add note to Windows docs about patch util MINOR: [Docs] Add note to Windows docs about patch util Oct 17, 2025
@github-actions github-actions bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Oct 17, 2025
@AlenkaF AlenkaF merged commit 52704cb into apache:main Oct 21, 2025
9 checks passed
@AlenkaF AlenkaF removed the awaiting committer review Awaiting committer review label Oct 21, 2025
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 52704cb.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 49 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants