Skip to content

Conversation

matshch
Copy link

@matshch matshch commented Sep 15, 2025

Rationale for this change

On newer Apple silicon CPUs there is more L2 CPU cache than expected by the current unit tests. This results in the unit test failing:

/tmp/nix-build-arrow-cpp-20.0.0.drv-0/source/cpp/src/arrow/util/io_util_test.cc:1099: Failure
Value of: l2 >= 32 * 1024 && l2 <= 12 * 1024 * 1024
  Actual: false
Expected: true
unexpected L2 size: 16777216
[  FAILED  ] CpuInfo.Basic (0 ms)

What changes are included in this PR?

The expected L2 CPU cache range is increased to 32KiB-64MiB to accommodate newer CPUs.

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

Copy link

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

See also:

@matshch matshch changed the title Update expected L2 CPU cache range to 32KiB-64MiB GH-47564: [C++] Update expected L2 CPU cache range to 32KiB-64MiB Sep 15, 2025
Copy link

⚠️ GitHub issue #47564 has been automatically assigned in GitHub to PR creator.

Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels Sep 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants