Skip to content

Conversation

TennyZhuang
Copy link
Contributor

@TennyZhuang TennyZhuang commented Sep 4, 2025

Rationale for this change

Fix a syntax error in Python. The argument is required.

What changes are included in this PR?

  • Fix a syntax error in pyarrow fs

Are these changes tested?

Yes

Are there any user-facing changes?

No

@github-actions github-actions bot added the awaiting review Awaiting review label Sep 4, 2025
Copy link

github-actions bot commented Sep 4, 2025

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

See also:

@TennyZhuang TennyZhuang changed the title [Python] Fix missing argument in pyarrow fs MINOR: [Python] Fix missing argument in pyarrow fs Sep 4, 2025
@pitrou
Copy link
Member

pitrou commented Sep 4, 2025

Two things:

  1. This is not a minor change as it's actually a bugfix, can you please open an issue for it?
  2. Can you also add a test to exercise this codepath? (obviously it wasn't tested before :-))

@TennyZhuang TennyZhuang changed the title MINOR: [Python] Fix missing argument in pyarrow fs GH-47559: [Python] Fix missing argument in pyarrow fs Sep 13, 2025
Copy link

⚠️ GitHub issue #47559 has been automatically assigned in GitHub to PR creator.

@TennyZhuang
Copy link
Contributor Author

@pitrou Hi, I've created the issue and added a test.

@github-actions github-actions bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Sep 15, 2025
@pitrou
Copy link
Member

pitrou commented Sep 18, 2025

@TennyZhuang It appears the test fails on at least some CI platforms, can you look at that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants