Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-45626: [CI][Docs] Remove Java related configurations from ci/docker/linux-apt-docs.dockerfile #45627

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

kou
Copy link
Member

@kou kou commented Feb 25, 2025

Rationale for this change

Java docs are generated in apache/arrow-java.

What changes are included in this PR?

Remove JDK and Maven related configurations.

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

@kou
Copy link
Member Author

kou commented Feb 25, 2025

@github-actions crossbow submit preview-docs

Copy link

⚠️ GitHub issue #45626 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Feb 25, 2025
Copy link

Revision: de6348e

Submitted crossbow builds: ursacomputing/crossbow @ actions-9063aa38f0

Task Status
preview-docs GitHub Actions

Copy link
Member

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. On a slightly different note, do you know if this dockerfile: java-jni-manylinux-201x.dockerfile is used anymore? While reviewing this I took a look and it seems it could also be removed right?

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels Feb 25, 2025
@kou
Copy link
Member Author

kou commented Feb 25, 2025

Good catch! We can remove it: #45631

@kou kou merged commit 6f1cbc3 into apache:main Feb 25, 2025
35 checks passed
@kou kou deleted the ci-docs-java branch February 25, 2025 23:55
@kou kou removed the awaiting merge Awaiting merge label Feb 25, 2025
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 6f1cbc3.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 20 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants