Skip to content

GH-45394: [C++] Handle Single-Line JSON Without Line Ending #45443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

GH-45394: [C++] Handle Single-Line JSON Without Line Ending #45443

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@ dependency-reduced-pom.xml
MANIFEST
compile_commands.json
build.ninja
build_debug/
build_release/

# Generated Visual Studio files
*.vcxproj
Expand Down
10 changes: 5 additions & 5 deletions cpp/src/arrow/dataset/file_json.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,11 +301,11 @@ Result<Future<ReaderPtr>> DoOpenReader(
std::move(state->stream), state->read_options, state->parse_options);
});
ARROW_ASSIGN_OR_RAISE(auto future, maybe_future);
return future.Then([](const ReaderPtr& reader) -> Result<ReaderPtr> { return reader; },
[path = source.path()](const Status& error) -> Result<ReaderPtr> {
return error.WithMessage("Could not open JSON input source '",
path, "': ", error);
});
return future.Then([](const ReaderPtr& reader) -> Result<ReaderPtr> {
return reader;
}, [path = source.path()](const Status& error) -> Result<ReaderPtr> {
return error.WithMessage("Could not open JSON input source '", path, "': ", error);
});
}

Future<ReaderPtr> OpenReaderAsync(
Expand Down