MINOR: [Format] Schema.fbs grammar -- improve Map key/value field docs readability#45024
MINOR: [Format] Schema.fbs grammar -- improve Map key/value field docs readability#45024akesling wants to merge 1 commit into
Conversation
kou
changed the title
| /// has two children: key type and the second the value type. The names of the | ||
| /// child fields may be respectively "entries", "key", and "value", but this is | ||
| /// not enforced. | ||
| /// has two children: the first of the key type and second of the value type. |
There was a problem hiding this comment.
I'm not good at English but we don't need one more the?
| /// has two children: the first of the key type and second of the value type. | |
| /// has two children: the first of the key type and the second of the value type. |
There was a problem hiding this comment.
It works grammatically either way, but the extra "the" isn't strictly necessary. Definite articles often need not be repeated in lists. I, personally, prefer the shorter form but defer to maintainers.
See https://english.stackexchange.com/questions/178767/definite-article-repetition-in-lists for a spot of context.
There was a problem hiding this comment.
OK. I'll merge this PR in the next week if nobody objects this PR.
github-actions
Bot
added
awaiting changes
|
Thank you for your contribution. Unfortunately, this pull request has been marked as stale because it has had no activity in the past 365 days. Please remove the stale label or comment below, or this PR will be closed in 14 days. Feel free to re-open this if it has been closed in error. If you do not have repository permissions to reopen the PR, please tag a maintainer. |
github-actions
Bot
added
the
Status: stale-warning
|
Sorry... I forgot to merge this... Anyway, thanks for your contribution. |
2 participants
Rationale for this change
To improve a comment.
What changes are included in this PR?
Improvement to the Map key/value field docs readability.
Are these changes tested?
N/A
Are there any user-facing changes?
No