Improvements for parquet writing performance #7824
Draft
+79
−30
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax.
Rationale for this change
The changes in this PR improve parquet writing performance for primitives without bloom filters by between 15% and 30%.
What changes are included in this PR?
There was not a single bottleneck to fix, instead several small improvements contributed to the performance increase:
BitWriter::put_value
todebug_assert
since these should never be triggered by users of the code and are not required for soundness.TrustedLen
and so avoids multiple capacity checks andBitIndexIterator
is more optimized for collecting non-null indices.Are these changes tested?
Logic should be covered by existing tests.
Are there any user-facing changes?
No, all changes are to implementation details and do not affect public apis.