Repository navigation
[57_maintenance] chore: update tokio to 1.54.1 to fix cargo audit CI - #11819
Merged
Merged
Conversation
tokio 1.54.0 was yanked and is the subject of RUSTSEC-2026-0384 (race condition in `tokio::time::Interval`). Bump the pinned version in the committed Cargo.lock to 1.54.1. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
alamb
added a commit
that referenced
this pull request
Oct 22, 2026
…11821) # Which issue does this PR close? - N/A (fixes CI on the `58_maintenance` branch) # Rationale for this change The `Audit` job fails on pushes to `58_maintenance` (for example https://github.com/apache/arrow-rs/actions/runs/39737710459) because an advisory was published against a version pinned in the committed `Cargo.lock`: - [RUSTSEC-2026-0384](https://rustsec.org/advisories/RUSTSEC-2026-0384): `tokio` 1.54.0 (race condition in `tokio::time::Interval`), fixed in 1.54.1. The 1.54.0 release has also been yanked. `main` (tokio 1.53.3) and `59_maintenance` (tokio 1.53.1) are not affected. `57_maintenance` pins the same 1.54.0 and gets the same fix in #11819. # What changes are included in this PR? Update only `tokio` in `Cargo.lock` from 1.54.0 to 1.54.1 (version and checksum). Running `cargo update -p tokio --precise 1.54.1` also re-unified the `windows-sys` dependency of five unrelated crates, so this PR applies just the `tokio` entry to keep the diff minimal. Verified locally that `cargo audit --ignore RUSTSEC-2026-0194 --ignore RUSTSEC-2026-0195 --ignore RUSTSEC-2026-0176 --ignore RUSTSEC-2026-0177` (the CI invocation) passes with only the one already-allowed `unmaintained` warning, and that the lockfile resolves with `cargo +1.85.0 metadata --locked`. tokio 1.54.1 has `rust-version = "1.85"`, matching the workspace MSRV. # Are these changes tested? CI # Are there any user-facing changes? No. This only affects the lockfile used for workspace builds and CI. Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
alamb
added a commit
to alamb/arrow-rs
that referenced
this pull request
Oct 22, 2026
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Jefffrey
added
the
development-process
Jefffrey
added a commit
that referenced
this pull request
Oct 23, 2026
# Which issue does this PR close? - Part of #11666 # Rationale for this change Prepare for the `57.3.2` patch release from the `57_maintenance` branch # What changes are included in this PR? 1. Update version to `57.3.2` 2. Move the `57.3.1` changelog entry into `CHANGELOG-old.md` 3. Add `57.3.2` CHANGELOG (see rendered version https://github.com/alamb/arrow-rs/blob/alamb/prepare_57.3.2/CHANGELOG.md) 4. Update `dev/release/update_change_log.sh` for the `57.3.2` release range Notes on the changelog: `update_change_log.sh` (github-changelog-generator) does not filter by branch, so running it picks up `main` PRs and misses the `57_maintenance` backports. The `57.3.2` entry was therefore written by hand in the same format as the `58.4.1` (#11822) and `59.3.2` (#11797) changelogs: all backported fixes are grouped under "Bug fixes", following how the corresponding `main` PRs were labeled, and the CI-only changes (#11728, #11777, #11784, #11819) are omitted. # Are these changes tested? By CI # Are there any user-facing changes? New version and changelog --------- Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com> Co-authored-by: Jefffrey <jeffrey.vo.australia@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
57_maintenancebranch)Rationale for this change
The
Auditjob fails on pushes to57_maintenance(for example https://github.com/apache/arrow-rs/actions/runs/39737507626/job/119686585080) because an advisory was published against a version pinned in the committedCargo.lock:tokio1.54.0 (race condition intokio::time::Interval), fixed in 1.54.1. The 1.54.0 release has also been yanked.main(tokio 1.53.3) and59_maintenance(tokio 1.53.1) are not affected.58_maintenancepins the same 1.54.0 and gets the same fix in a separate PR.What changes are included in this PR?
Update only
tokioinCargo.lockfrom 1.54.0 to 1.54.1 (version and checksum). Runningcargo update -p tokio --precise 1.54.1also re-unified thewindows-sysdependency of five unrelated crates, so this PR applies just thetokioentry to keep the diff minimal.Verified locally that
cargo audit --ignore RUSTSEC-2026-0194 --ignore RUSTSEC-2026-0195 --ignore RUSTSEC-2026-0176 --ignore RUSTSEC-2026-0177(the CI invocation) passes with only the two already-allowedunmaintainedwarnings, and that the lockfile resolves withcargo +1.85.0 metadata --locked. tokio 1.54.1 hasrust-version = "1.85", matching the workspace MSRV.Are these changes tested?
CI
Are there any user-facing changes?
No. This only affects the lockfile used for workspace builds and CI.