Repository navigation
[58_maintenance] fix(arrow-array): PrimitiveRunBuilder was buggy after finish - #11704
Merged
Merged
Conversation
…che#11326) - Closes apache#11325. `PrimitiveRunBuilder::finish` did not reset `prev_run_end_index`, so a reused builder kept the previous batch's last run index. That resulted in various misbehavior, like either dropping data or panicking, on a subsequent `finish` call. See above. Yes; new test added. No. Issue spotted and fix developed with Claude Code (Opus 5.5); I have reviewed and understand the resulting code.
github-actions
Bot
added
the
arrow-core
4 of 5 tasks
Jefffrey
added a commit
that referenced
this pull request
Oct 21, 2026
…oc, MIRI and integration test fixes (#11727) # Which issue does this PR close? - Part of #11665 (58.4.1 release) # Rationale for this change CI on the 58_maintenance branch is red on every PR (e.g. #11365, #11703, #11704, #11705, #11707) for reasons unrelated to those PRs. # What changes are included in this PR? - Check in the root `Cargo.lock`, the same approach as #9941 - Backport #11305: remove duplicate `homepage` entries and let rustdoc infer the targets of five `arrow-avro` intra-doc links. - Backport #10433: stop asserting on the unstable `TryFromIntError` message in the `arrow-schema` tests. - Backport #9888: support `ListView`, `BinaryView` and `RunEndEncoded` in the integration test JSON parser. # Are these changes tested? Yes by CI # Are there any user-facing changes? No. --------- Signed-off-by: Jiawei Zhao <Phoenix500526@163.com> Co-authored-by: Aditya Mishra <bit2swaz@gmail.com> Co-authored-by: Dewey Dunnington <dewey@wherobots.com> Co-authored-by: Copilot <copilot@github.com> Co-authored-by: Jeffrey Vo <jeffrey.vo.australia@gmail.com> Co-authored-by: Phoenix <Phoenix500526@163.com> Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
Jefffrey
marked this pull request as ready for review
October 21, 2026 11:26
alamb
approved these changes
Oct 21, 2026
Contributor
|
Merging as MSRV failure is unrelated. I will fix in this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PrimitiveRunBuilderwas buggy afterfinish#1132658.4.1(October 2026) #11665Cherry-pick of a5ba6a2