Repository navigation
[59_maintenance] fix(arrow-data): account for FixedSizeList parent offset in MutableArrayData - #11683
Merged
Merged
Conversation
…rayData (apache#11636) - Closes apache#11588. `MutableArrayData::extend` on a `FixedSizeList` with a nonzero parent offset copied the child values from the start of the child instead of from the offset. `build_extend` in `transform/fixed_size_list.rs` adds `array.offset()` to `start` before computing the child range, the same way apache#10934 did for structs. Yes, `test_extend_fixed_size_list_accounts_for_parent_offset` in `arrow-data/src/data.rs` (next to the struct test from apache#10934). It fails without the fix. No. AI use: I used Claude Code to find the cause and write the fix and test. I reviewed the change and checked that the test fails without the fix.
github-actions
Bot
added
the
arrow-core
4 of 5 tasks
Jefffrey
marked this pull request as ready for review
October 18, 2026 14:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
59.3.2(October 2026) #11664Cherry-pick of 9827aaa