Repository navigation
[59_maintenance] fix(arrow-array): use the field's type id in dense union logical_nulls - #11680
Merged
Merged
Conversation
apache#11643) # Which issue does this PR close? - Closes apache#11595. # Rationale for this change A dense union with a single field whose type id is not 0 reported no logical nulls, so `logical_null_count`, `is_null` and `is_not_null` were wrong for it. # What changes are included in this PR? The single-field path of `UnionArray::logical_nulls` passed the child nulls to `gather_nulls` under type id 0. It now passes the field's own type id, enumerating `self.fields` the same way `fields_logical_nulls` does. # Are these changes tested? Yes, `test_dense_union_one_field_nonzero_type_id_logical_nulls`. It fails without the fix. # Are there any significant user-facing changes? No. AI use: I used Claude Code to find the cause and write the fix and test. I reviewed the change and checked that the test fails without the fix.
4 of 5 tasks
github-actions
Bot
added
the
arrow-core
Jefffrey
marked this pull request as ready for review
October 18, 2026 13:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
59.3.2(October 2026) #11664Cherry-pick of 24c53c7