Repository navigation
[59_maintenance] Fix sliced sparse union ArrayData conversion - #11679
Merged
Merged
Conversation
# Which issue does this PR close? - Closes apache#11582 # Rationale for this change Converting sliced sparse union `ArrayData` into an array currently reads values outside the slice. A single-child union can also return a logical null mask longer than the resulting array. # What changes are included in this PR? Apply the parent offset and length to sparse child data before constructing the child arrays. Dense children retain their existing offsets and lengths. # Are these changes tested? Regression tests compare conversion from sliced `ArrayData` with direct union slicing, including nonzero offsets, truncation at offset zero, empty slices, custom type IDs, nullable values, and a dense-union control. AI assistance was used to analyze the conversion path and draft the code, regression tests, and this description. # Are there any significant user-facing changes? No public API changes.
4 of 5 tasks
github-actions
Bot
added
the
arrow-core
Jefffrey
marked this pull request as ready for review
October 18, 2026 13:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
59.3.2(October 2026) #11664Cherry-pick of a934112