Repository navigation
[58_maintenance] Upgrade legacy Thrift dependency to 0.23 - #11365
Merged
alamb merged 7 commits intoOct 22, 2026
Merged
Conversation
Contributor
|
is this a request for a 58.4.1 patch release? |
4 of 5 tasks
Contributor
|
update: we will be making a patch release, see |
Contributor
|
Here is a PR to get CI clean on this branch |
Jefffrey
added a commit
that referenced
this pull request
Oct 21, 2026
…oc, MIRI and integration test fixes (#11727) # Which issue does this PR close? - Part of #11665 (58.4.1 release) # Rationale for this change CI on the 58_maintenance branch is red on every PR (e.g. #11365, #11703, #11704, #11705, #11707) for reasons unrelated to those PRs. # What changes are included in this PR? - Check in the root `Cargo.lock`, the same approach as #9941 - Backport #11305: remove duplicate `homepage` entries and let rustdoc infer the targets of five `arrow-avro` intra-doc links. - Backport #10433: stop asserting on the unstable `TryFromIntError` message in the `arrow-schema` tests. - Backport #9888: support `ListView`, `BinaryView` and `RunEndEncoded` in the integration test JSON parser. # Are these changes tested? Yes by CI # Are there any user-facing changes? No. --------- Signed-off-by: Jiawei Zhao <Phoenix500526@163.com> Co-authored-by: Aditya Mishra <bit2swaz@gmail.com> Co-authored-by: Dewey Dunnington <dewey@wherobots.com> Co-authored-by: Copilot <copilot@github.com> Co-authored-by: Jeffrey Vo <jeffrey.vo.australia@gmail.com> Co-authored-by: Phoenix <Phoenix500526@163.com> Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Contributor
|
run benchmark arrow_reader metadata row_group_index_reader |
|
🤖 Benchmark starting (GKE) | trigger Target: arrow_reader Sharding factor: 1 (1 workers). Comparing codex/parquet58-thrift-security (43b045e) to 913bab2 (merge-base) diff Run configurationrun benchmark arrow_reader
shards: 1
Results will be posted when all workers finish. File an issue against this benchmark runner |
|
🤖 Benchmark starting (GKE) | trigger Target: metadata Sharding factor: 1 (1 workers). Comparing codex/parquet58-thrift-security (43b045e) to 913bab2 (merge-base) diff Run configurationrun benchmark metadata
shards: 1
Results will be posted when all workers finish. File an issue against this benchmark runner |
|
🤖 Benchmark starting (GKE) | trigger Target: row_group_index_reader Sharding factor: 1 (1 workers). Comparing codex/parquet58-thrift-security (43b045e) to 913bab2 (merge-base) diff Run configurationrun benchmark row_group_index_reader
shards: 1
Results will be posted when all workers finish. File an issue against this benchmark runner |
Contributor
|
FWIW thrift is only used in this version for the legacy format crate I think -- we removed it in later releases -- so I don't think this change will impact any users directly as the thrift crate's code is not used to deserialize the metadata |
|
🤖 Benchmark completed (GKE) | trigger Target: row_group_index_reader Comparing codex/parquet58-thrift-security (43b045e) to 913bab2 (merge-base) diff Run configurationrun benchmark row_group_index_reader
shards: 1
DetailsPer-runner informationrow_group_index_reader — shard 1/1Node: gk3-benchmark-cluster-nap-q6wpalag-bfe0cb07-gks8 Instance: c4a-highmem-16 (12 vCPU / 65 GiB) uname: BENCH_COMMAND: cargo bench --features=arrow,async,test_common,experimental,object_store --bench row_group_index_readerCPU Details (lscpu)Resource Usagebase (merge-base)
branch
File an issue against this benchmark runner |
|
🤖 Benchmark completed (GKE) | trigger Target: metadata Comparing codex/parquet58-thrift-security (43b045e) to 913bab2 (merge-base) diff Run configurationrun benchmark metadata
shards: 1
DetailsPer-runner informationmetadata — shard 1/1Node: gk3-benchmark-cluster-nap-q6wpalag-5c6124f8-g8bf Instance: c4a-highmem-16 (12 vCPU / 65 GiB) uname: BENCH_COMMAND: cargo bench --features=arrow,async,test_common,experimental,object_store --bench metadataCPU Details (lscpu)Resource Usagebase (merge-base)
branch
File an issue against this benchmark runner |
Jefffrey
approved these changes
Oct 22, 2026
|
🤖 Benchmark completed (GKE) | trigger Target: arrow_reader Comparing codex/parquet58-thrift-security (43b045e) to 913bab2 (merge-base) diff Run configurationrun benchmark arrow_reader
shards: 1
DetailsPer-runner informationarrow_reader — shard 1/1Node: gk3-benchmark-cluster-nap-q6wpalag-9bd26331-bg42 Instance: c4a-highmem-16 (12 vCPU / 65 GiB) uname: BENCH_COMMAND: cargo bench --features=arrow,async,test_common,experimental,object_store --bench arrow_readerCPU Details (lscpu)Resource Usagebase (merge-base)
branch
File an issue against this benchmark runner |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parquet 58 still depends on Thrift 0.17, which is affected by GHSA-2f9f-gq7v-9h6m. Upgrade the legacy Thrift dependency to 0.23 on
58_maintenance, preserving the Arrow/Parquet 58 APIs for downstream readers such as Paimon.Add regressions for compact-protocol Statistics round trips and rejection of an oversized binary field before allocation. The existing internal Parquet decoder is unchanged.
Validation:
cargo +stable test -p parquet --libpasses all 1,090 tests, including the 12 Thrift-related tests; formatting andgit diff --checkpass.