test(csharp/src/Drivers): add Spice.ai test target#2961
Conversation
051f8ef to
af18d6a
Compare
|
Shouldn't we test the driver directly instead of through C#? |
|
@lidavidm - thank you for review!
Good point. The reason the test was added based on the C# interop driver is to cover both:
Looking for recommendations/guidance here, will update as needed. |
|
@zeroshade what's your opinion here? |
I'm happy to have both types of tests; we also have C# tests for Flight interop with Denodo and Dremio. The bulk of the maintenance is likely to be in the Docker test fixture and that can be shared. |
CurtHagenlocher
left a comment
There was a problem hiding this comment.
Thanks! I'm not the best person to comment on the workflow and test setup changes, but the C# changes look good to me, modulo a few nits.
|
(Sorry for hijacking here but... @CurtHagenlocher could you check apache/arrow#46752 (comment) ? I want to proceed moving |
Add Spice.ai OSS test target for FlightSQL C# interop driver to test compatibility with arrow-rs FlightSQL implementation.
SpiceAIenvironment type support (test data, example configuration)FligthSQL C# Interopintegration tests. This can be extended to include more tests targets via configuration files similar toci/configs/flightsql-spiceai.jsonadded in this PRExample test run: https://github.com/apache/arrow-adbc/actions/runs/15597223474/job/43930217202?pr=2961
Testing against ADBC helped to identify and fix:
GetDbSchemasandGetTablesschemas to fully match the protocol arrow-rs#7638