-
Notifications
You must be signed in to change notification settings - Fork 366
[AMORO-3531] Drop support for java8 #3899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3899 +/- ##
============================================
+ Coverage 28.82% 28.94% +0.11%
- Complexity 3838 3847 +9
============================================
Files 625 631 +6
Lines 50514 50722 +208
Branches 6455 6496 +41
============================================
+ Hits 14560 14680 +120
- Misses 34928 34985 +57
- Partials 1026 1057 +31
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Should we drop support for Java8 in the next release? @zhoujinsong @baiyangtx @klion26 |
|
is there an ETA for next release? |
|
I am okay to drop JDK8 in the next version, if it keeps us from uprading the iceberg version. |
|
As we have not deprecated JDK8 in 0.8.x, maybe we need to deprecate the jdk8 in 0.9.x and remove it in the version after 0.9.x(0.10.x or 1.0.x ). If we want to remove the JDK8 support more quickly, maybe we can make an earlier release for this. |
+1. In my view, the legacy burden of JDK 8 has become a hindrance to the advancement of the community. |
Why are the changes needed?
Close #3531
This PR removes support for Java 8 across the project. Reasons:
Java 8 is end-of-life and no longer receives public updates or security patches.
Modern libraries and frameworks increasingly require Java 11+.
Dropping Java 8 simplifies code maintenance and allows use of newer language features and APIs.
Improves compatibility with current cloud and container environments, which default to Java 11 or higher.
Brief change log
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation