Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update taskflow.rst #48108

Merged
merged 2 commits into from
Mar 23, 2025
Merged

Update taskflow.rst #48108

merged 2 commits into from
Mar 23, 2025

Conversation

fedorkobak
Copy link
Contributor

@fedorkobak fedorkobak commented Mar 23, 2025

Fix data mismatch in "Passing Arbitrary Objects As Arguments" section


The example URL (https://www.ncei.noaa.gov/access/monitoring/climate-at-a-glance/global/time-series/globe/land_ocean/ytd/12/1880-2022.json) returns a data structure that is incompatible with to_fahrenheit. The original code attempts to operate on a dict as if it were a numeric datatype, causing an error and preventing the example from being executed.

Fix data mismatch in "Passing Arbitrary Objects As Arguments" section
Copy link

boring-cyborg bot commented Mar 23, 2025

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://s.apache.org/airflow-slack

@jedcunningham
Copy link
Member

Merging. Static check failure is unrelated.

@jedcunningham jedcunningham merged commit 550b2a7 into apache:main Mar 23, 2025
40 of 41 checks passed
Copy link

boring-cyborg bot commented Mar 23, 2025

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

@jedcunningham
Copy link
Member

Thanks @fedorkobak! Congrats on your first commit 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants