-
Notifications
You must be signed in to change notification settings - Fork 15.5k
(Re)move old dependencies from the old FAB UI #48007
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Love to see all these deps moving away from airflow-core! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, let's see if tests are passing
Tests are failing because of |
Yours is a bit more comprehensive than mine (#47958). I can do the password extra removal separately. |
Better to re-do it in the new form after #47798 |
Should be rebased now after airflow-core move as the dependncies moved to "airflow-core/pyproject.toml" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs rebase / conflicts removal but it's very cool change :)
adcff87
to
e8149ac
Compare
Deleted hatch_build by mistake. Ooops :) |
e8149ac
to
d60eb1f
Compare
FYI With getting rid of |
d60eb1f
to
01b5075
Compare
Hmmm, somewhere we are still/yet again missing the dep on werkzeug:
I've run out of spare time this weekend, I'll take a look on Monday |
Looks tests only. Possibly we shoud move the tests that use it to FAB (they are really testing "fab provider" variant of the providers_manager) |
Fix here: #48113 |
331d651
to
7efd12d
Compare
seems like fast_api/svcs has another implicit flask dependency |
but likely it's because it is there in an old version of it - as only "lowest dependencies" are impacted. |
Most likely: - fastapi==0.115.12
+ fastapi==0.112.4 |
Possibly fastapi/fastapi#12747 (0.115.5) |
Looking |
This is an odd one:
|
7efd12d
to
215a3e9
Compare
Ah, I didn't resolve conflicts correctly. Lets try this |
Some of these deps, like python-nvd3 or markdown-it-py, are simply not used anymore, while others are still used and the dep has been moved to the fab provider where it is actually used.
215a3e9
to
3148d60
Compare
Thanks for the assist @potiuk |
Some of these deps, like python-nvd3 or markdown-it-py, are simply not used anymore, while others are still used and the dep has been moved to the fab provider where it is actually used.
Some of these deps, like python-nvd3 or markdown-it-py, are simply not used anymore, while others are still used and the dep has been moved to the fab provider where it is actually used.
Some of these deps, like python-nvd3 or markdown-it-py, are simply not used anymore, while others are still used and the dep has been moved to the fab provider where it is actually used.
Some of these deps, like python-nvd3 or markdown-it-py, are simply not used
anymore, while others are still used and the dep has been moved to the fab
provider where it is actually used.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.