Merged
Conversation
It turns out that the way SocketIO (which is the class you get from) `sock.makefile` doesn't _actually_ close the socket when you close the IO object, which normally is fine as the socket won't be around and will clean up nicely, but due to forking and us _actually_ wanting to close the socket, we need to be a bit more careful about how we do this. It also turns out I misunderstood when `set_inheritable` applies. It is not about when forking, but specifically only when execing. So I've removed that setting as we don't need it. Closes #46048, and relates to #47294 (it might close it, it might not, unsure at this point)
Member
Author
|
Shoutout to @tirkarthi for the easy reproduction steps. |
jedcunningham
approved these changes
Mar 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It turns out that the way SocketIO (which is the class you get from)
sock.makefiledoesn't actually close the socket when you close the IOobject, which normally is fine as the socket won't be around and will clean up
nicely, but due to forking and us actually wanting to close the socket, we
need to be a bit more careful about how we do this.
It also turns out I misunderstood when
set_inheritableapplies. It is notabout when forking, but specifically only when execing. So I've removed that
setting as we don't need it.
Closes #46048, and relates to #47294 (it might close it, it might not, unsure
at this point)
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.