Fix authentication for cases where webserver.base_url is not defined and worker is not using localhost in 2.10. #45785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jscheffl
added
type:bug-fix
jscheffl
force-pushed
the
bugfix/fix-edge-authentication-in-2-10-when-base-url-not-set
branch
from
169c2b1 to
9324cd1
Compare
kaxil
approved these changes
Jan 20, 2025
…and worker is not using localhost in 2.10.
jscheffl
force-pushed
the
bugfix/fix-edge-authentication-in-2-10-when-base-url-not-set
branch
from
cb906f2 to
6302a35
Compare
dauinh
pushed a commit
to dauinh/airflow
that referenced
this pull request
Jan 24, 2025
…and worker is not using localhost in 2.10. (apache#45785) * Fix authentication for cases where webserver.base_url is not defined and worker is not using localhost in 2.10. * Move Edge to new provider structure
got686-yandex
pushed a commit
to got686-yandex/airflow
that referenced
this pull request
Jan 30, 2025
…and worker is not using localhost in 2.10. (apache#45785) * Fix authentication for cases where webserver.base_url is not defined and worker is not using localhost in 2.10. * Move Edge to new provider structure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing edge deployment with @cmarteepants we found one problem when running Edge Provider in Airflow 2.10.4 - The authentication required to set webserver.base_url parameter to cut the server name from the called URL. This leads to failures when the base_url is not set and you run edge worker not on localhost.
This PR changes authentication in 2.10 to be the same like in main and not using base_url but take only the authentication URL part after the API prefix.