AIP-38 Better markdown rendering #45459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierrejeambrun
requested review from
bbovenzi,
ryanahamilton and
jscheffl
as code owners
bbovenzi
reviewed
Jan 7, 2025
pierrejeambrun
force-pushed
the
fix-markdown-rendering
branch
from
58590e8 to
9ede3be
Compare
bbovenzi
approved these changes
Jan 8, 2025
dstandish
pushed a commit
to astronomer/airflow
that referenced
this pull request
Jan 8, 2025
agupta01
pushed a commit
to agupta01/airflow
that referenced
this pull request
Jan 13, 2025
HariGS-DB
pushed a commit
to HariGS-DB/airflow
that referenced
this pull request
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only the last commit is relevant. Depends on #45434
This fixes the markdown rendering. Due to the ChakraUI CSS reset (good practice), native elements have no styling. We need to remap html tags to Chakra components in the markdown renderer. Example of the css reset, those are correctly h1, ul, li tags, but no style are applied (CSS reset):
Before:
After: