-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AIP-72: Exposing 'extra_dejson' on Connection definition #45448
AIP-72: Exposing 'extra_dejson' on Connection definition #45448
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just realized I had added some part of extra_dejson yesterday night before creating that issue:
but the tests you have here are still valid, could you rebase
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 comments but lgtm otherwise
Co-authored-by: Kaxil Naik <[email protected]>
The failure was due to a timeout. Retriggering |
closes: #45443
Connection model supports
extra_dejson
which is a deserialised value ofextra
as a python dictionary: https://airflow.apache.org/docs/apache-airflow/stable/templates-ref.html#airflow-connections-in-templatesFor AIP 72 and enablement of multi language support, we should have this lie in the task sdk side, so that the API client and server cleanly only communicate in JSON strings and the responsibility of deserialising and serialising lies on the client whilst sending to task sdk.
Testing
DAG:
Steps:
In the existing connections, edited the
airflow_db
to add extra:Added
extra
as:Ran the DAG to see results
Logs:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.