Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix generate-constraints job condition in canary run #45409

Conversation

gopidesupavan
Copy link
Member

@gopidesupavan gopidesupavan commented Jan 5, 2025

One more interesting thing :).

generate-constraints job skipped when UI only changes, this fine for normal PR builds, but for canary run we should trigger this job, this skip causes further dependent jobs skipped :)

https://github.com/apache/airflow/actions/runs/12619970959/job/35165290069


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Copy link
Contributor

@jscheffl jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!
Our CI seems to be full of surprises the more you look into it :-D

@gopidesupavan
Copy link
Member Author

Merging now, one test failed not related to this, it seems test related to auth manager. will look into separate.

@gopidesupavan gopidesupavan merged commit ca98be9 into apache:main Jan 5, 2025
89 of 90 checks passed
@gopidesupavan
Copy link
Member Author

Good catch! Our CI seems to be full of surprises the more you look into it :-D

Yeah good that the skipped jobs are visible in UI :)

@gopidesupavan gopidesupavan deleted the fix-generate-constraints-job-condition branch January 5, 2025 20:01
@potiuk
Copy link
Member

potiuk commented Jan 5, 2025

Good catch! Our CI seems to be full of surprises the more you look into it :-D

It is (or should be) very simple - we should strongly avoid complex conditions in the yaml files - and do all the logic calculation in selective_checks - they are unit testable and "python" :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants