-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replacing gunicornmontor with uvicorn.run() #45103
Replacing gunicornmontor with uvicorn.run() #45103
Conversation
…icorn-with-uvicorn-run
1a74394
to
85305fc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All for it. 👍
Thanks for the metrics that encourage that this is the good choice.
Just a small question.
…omer/airflow into replace-gunicorn-with-uvicorn-run
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, looks good.
Leaving some time for others to participate in the discussion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI need fixing, most likely CLI tests need to be updated.
…omer/airflow into replace-gunicorn-with-uvicorn-run
Fixed tests after updating |
Ok, I think we left enough time for people to participated in case they feel that some other options are necessary. We can always improve later, merging. |
* replace gunicorm with uvicorn.run() * fixing tests * Daemonized fastapi server * fixing setproctitle format * updating setproctitle
* replace gunicorm with uvicorn.run() * fixing tests * Daemonized fastapi server * fixing setproctitle format * updating setproctitle
Related: #43035
These are the stats comparing
uvicorn.run()
withGunicorn + GunicornMonitor
Comparison: Uvicorn vs. Gunicorn Performance
Request Statistics
Observations
Response Times:
Failures:
RemoteDisconnected
errors. This could indicate potential issues in connection handling under load.Performance Consistency:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.