Set Autocomplete Off on Login Form - Main #44929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geraj1010
requested review from
ryanahamilton,
ashb,
bbovenzi,
pierrejeambrun and
jscheffl
as code owners
boring-cyborg
bot
added
area:UI
ephraimbuddy
approved these changes
Dec 14, 2024
jscheffl
force-pushed
the
airflow_44019_main
branch
from
5d7dbbf to
e19e417
Compare
jscheffl
approved these changes
Dec 14, 2024
|
Small issue in static check, can you resolve this? Best is to use pre-commit locally then you can catch it before submitting to CI |
Yea I can see that. Perhaps maybe next iteration can turn this into a Webserver environment variable/Airflow Configuration setting? |
jscheffl
added
the
backport-to-v2-10-test
Right on, thanks for the heads up. All fixed now. |
jscheffl
approved these changes
Dec 15, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Dec 15, 2024
* #44019 - Set autocomplete to off for username and password login form * fixed static check (cherry picked from commit c77c7f0) Co-authored-by: James Regan <[email protected]>
Backport successfully created: v2-10-test
|
github-actions bot
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Dec 15, 2024
* apache#44019 - Set autocomplete to off for username and password login form * fixed static check (cherry picked from commit c77c7f0) Co-authored-by: James Regan <[email protected]>
romsharon98
pushed a commit
that referenced
this pull request
Dec 15, 2024
* #44019 - Set autocomplete to off for username and password login form * fixed static check (cherry picked from commit c77c7f0) Co-authored-by: James Regan <[email protected]>
kaxil
pushed a commit
that referenced
this pull request
Dec 17, 2024
* #44019 - Set autocomplete to off for username and password login form * fixed static check (cherry picked from commit c77c7f0) Co-authored-by: James Regan <[email protected]>
LefterisXefteris
pushed a commit
to LefterisXefteris/airflow
that referenced
this pull request
Jan 5, 2025
* apache#44019 - Set autocomplete to off for username and password login form * fixed static check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #44019
Updated main Javascript to apply autocomplete="off" to both username and password inputs on login page. This will help prevent the browser from providing hints for the username (and password), as requested in the Issue.
Based on Flask-AppBuilder source code, i.e. https://github.com/dpgaspar/Flask-AppBuilder/tree/master/flask_appbuilder/templates/appbuilder/general/security (see login_db.html and login_ldap.html), this should work for both AUTH_DB (default) and AUTH_LDAP authentication, since they both apparently use the same HTML elements in the form.